Master Audio. Mirror. Authority. [possible fix as well]

scornflake
New Member

Posts: 20

Master Audio. Mirror. Authority. [possible fix as well] Apr 3, 2022 23:07:36 GMT

Quote

Post by scornflake on Apr 3, 2022 23:07:36 GMT

Helllooooo!

I'm trying to understand how MA networking audio works. (using MA2022 1.0.1, Unity 2020.3.31)
I've got a single MA setup in a scene. I'm using ParrelSync to run two copies of the game on the same host; and they are direct connection via Kcp.
All to say; I can run around with a couple of characters in game just fine.

Re MA setup:
The MAsterAudio component has got the Master Audio Multiplayer Adapter added to the MA gameobject.
NetworkIdentity is setup, and valid on the MA, like so (see 1st attachment)

This is what I get when I call the MAMA from code:

Trying to send command for object without authority. System.Void DarkTonic.MasterAudio.Multiplayer.MasterAudioMultiplayerAdapter::CmdPlaySoundAtTransform(System.String,System.UInt32,System.String,System.Single,System.Boolean,System.Single,System.Single,System.String)
UnityEngine.Debug:LogWarning (object)
Mirror.NetworkBehaviour:SendCommandInternal (string,Mirror.NetworkWriter,int,bool) (at Assets/Mirror/Runtime/NetworkBehaviour.cs:218)
DarkTonic.MasterAudio.Multiplayer.MasterAudioMultiplayerAdapter:CmdPlaySoundAtTransform (string,uint,string,single,bool,single,single,string)
DarkTonic.MasterAudio.Multiplayer.MasterAudioMultiplayerAdapter:PlaySoundAtTransform (string,bool,string,UnityEngine.Transform,single,System.Nullable`1<single>,single,string) (at Assets/Plugins/DarkTonic/MasterAudioMultiplayer/MasterAudioMultiplayerAdapter.cs:2872)
DarkTonic.MasterAudio.Multiplayer.MasterAudioMultiplayerAdapter:PlaySound3DAtTransform (string,UnityEngine.Transform,single,System.Nullable`1<single>,single,string) (at Assets/Plugins/DarkTonic/MasterAudioMultiplayer/MasterAudioMultiplayerAdapter.cs:259)
BeLibs.Environment.Audio.SoundSubstance:Footstep (UnityEngine.Transform) (at Assets/BeLibs/Environment/Audio/SoundSubstance.cs:39)
BeLibs.Environment.Audio.PlayerMovementSounds:PlayFootstepSound () (at Assets/BeLibs/Environment/Audio/PlayerMovementSounds.cs:337)
BeLibs.Environment.Audio.PlayerMovementSounds:PlaySoundsBasedOnState () (at Assets/BeLibs/Environment/Audio/PlayerMovementSounds.cs:267)
BeLibs.Environment.Audio.PlayerMovementSounds:Update () (at Assets/BeLibs/Environment/Audio/PlayerMovementSounds.cs:171)

The transform being passed in is valid, and I've verified that it's network id is authoritative.

So here what I don't understand:

MA's network adapter does this:
Instance.CmdPlaySoundAtTransform(sType, viewId.Value, transPath, volPercentage, useSpecificPitch, pitchVal, delaySoundTime, variationName);

Two things:
1) The network identity of "Instance" is *not* authoratitive. Accoring to mirror docs:

Commands are sent from player objects on the client to player objects on the server. For security, Commands can only be sent from YOUR player object by default, so you cannot control the objects of other players. You can bypass the authority check using [Command(requiresAuthority = false)]

From my experience that means the object attempting to execute the [Command] on the server needs to be authoritative.
So I feel I'm missing something here. It seems like the MA network adapter is trying to send a server side Cmd, but will never be able to, because it (Instance), itself isn't authoratitive.

2) Even if it *could* send it, how does it make its way to other players?
For other players to hear the audio, doesn't a message have to be sent to those clients?
A [Command] by itself only sends a message to the server. And I see no code within the adapter than then broadcasts this out to all clients.

I figure this must all be tested and working, or I'm missing something really obvious, or my understanding of Mirror is very wrong.

Any tips / suggestions / help?

------------

What I had assumed should be happening as far as I understand Mirror:
1) Client sends message to server to say "play this audio". ([Command] attribute, client->server)
2) Server receives that message, and sends a RPC to all clients (excluding the owner, since it's already taken some action for that call locally). This'd be a Mirror ClientRpc attribute, e.g: [ClientRpc(includeOwner=false)].

unless im going nuts; what's missing is (2) above (well, that and getting the call to the server in the first place).

Attachments:

Last Edit: Apr 4, 2022 11:32:26 GMT by scornflake

scornflake
New Member

Posts: 20

Master Audio. Mirror. Authority. [possible fix as well] Apr 4, 2022 11:28:34 GMT

Quote

Post by scornflake on Apr 4, 2022 11:28:34 GMT

Here's some code that does work, across clients:

 /// <summary>

        /// This is an RPC used internally, do not call it.

        /// </summary>

        [Command(requiresAuthority = false)]

        public void CmdPlaySoundAtTransform(string sType, uint sourceViewId, string transformPath, float volPercentage, bool useSpecificPitch, float pitch, float delaySoundTime, string variationName)

        {

            var functionName = AudioRPC.CmdPlaySoundAtTransform.ToString();

            /* Probably don't need this unless you want to verify on the server that the netId is valid and not do the Rpc* */

            var callerTrans = FindTransformForReplicatedAudio(sourceViewId, transformPath, functionName);

            if (callerTrans == null)

            {

                return;

                // couldn't find the location to play on. Turn on LogDiagnostics if you want to see the message why in the Console.

            }



            RpcPlaySound3DAtTransformAndForget(sType, sourceViewId, transformPath, volPercentage, useSpecificPitch, pitch, delaySoundTime, variationName);

        }



        [ClientRpc(includeOwner = false)]

        private void RpcPlaySound3DAtTransformAndForget(string sType, uint sourceViewId, string transformPath, float volPercentage, bool useSpecificPitch, float pitch, float delaySoundTime, string variationName)

        {

            var functionName = AudioRPC.CmdPlaySoundAtTransform.ToString();

            var callerTrans = FindTransformForReplicatedAudio(sourceViewId, transformPath, functionName);

            float? pitchToUse = null;

            if (useSpecificPitch)

            {

                pitchToUse = pitch;

            }



            MasterAudio.PlaySound3DAtTransformAndForget(sType, callerTrans, volPercentage, pitchToUse, delaySoundTime, variationName);

        }

It requries that CanSendRPCs is changed, so that a client can send the command to the server initially.

public static bool CanSendRPCs

        {

            get

            {
		// for a remote client, that isnt the host. Yes, we DO want to talk to the server

                if (NetworkClient.active && NetworkClient.isConnected && !NetworkClient.isHostClient)


                {

                    return true;

                }



                if (NetworkServer.connections.Count <= 1)

                {

		....

With above, it would be more 'correct' to call CanSendRPCs CanSendCommands (since it's deciding: 'can this client talk to the server?' and 2ndly that 'rpc' in mirror speak is server->client messaging)
With that in mind; I dunno if you need any code in there other than "is this client connected and not the host?" it'd only ever be called from a client (be that host or non-host client, same code).

Hopefully above is useful. Unless I've understood the universe (And mirror) compleeeeeetely wrong.

Last Edit: Apr 4, 2022 11:38:17 GMT by scornflake

scornflake New Member Posts: 20 Posts: 20	Master Audio. Mirror. Authority. [possible fix as well] Apr 4, 2022 11:39:11 GMT Quote Select Post Deselect Post Link to Post Member Give Gift Back to Top Post by scornflake on Apr 4, 2022 11:39:11 GMT just realized my 'CanSendRPCs' mod is fine if considering hosted games, but I didnt' take into account dedicated servers. its late tho. I'll ponder this tomorrow.

DarkTonic Dev Administrator Posts: 4,386 Posts: 4,386	Master Audio. Mirror. Authority. [possible fix as well] Apr 4, 2022 18:20:47 GMT Quote Select Post Deselect Post Link to Post Member Give Gift Back to Top Post by DarkTonic Dev on Apr 4, 2022 18:20:47 GMT Thank you for the info. Let me know what else you discover. I'll post any updates as well.

scornflake
New Member

Posts: 20

Master Audio. Mirror. Authority. [possible fix as well] Apr 4, 2022 18:41:49 GMT

Quote

Post by scornflake on Apr 4, 2022 18:41:49 GMT

Unless I'm mistaken; I think all RPCs of MA would need some modification similar to above. i.e: Actual Client -> [Command(requiresAuthority = false)] -> [ClientRpc(includeOwner = false)]

What's there now (if it could send a msg to server, which I cant see how) would just play audio on the server. Not all clients. In fact if you think about dedicated servers for a mo, it serves to show why I think the current solution is broke. Msgs would go to the dedicated, and play there. Only there. [Commands] to my knowledge do not auto execute on clients. Only server.

I don't want to presume I *know* Mirror; having only been using it for 1-2months. More or less why I've asked if I'm also missing something... seems like a big thing to miss

For a dedicated server, clients would still send [Commands] to it. So their logic for 'CanSendRPC' would be "am I connected?". So actually maybe the code "if (NetworkClient.active && NetworkClient.isConnected && !NetworkClient.isHostClient)" is actually fine. I've had one coffee and I can't think of a case it wont work

Only other optimization I'd consider later would be to restrict sending of the messages to within a certain radius of other players. But thats getting waaaaay ahead of myself (like, maybe make it all work, first?)

Last Edit: Apr 4, 2022 18:45:53 GMT by scornflake

DarkTonic Dev
Administrator

Posts: 4,386

Master Audio. Mirror. Authority. [possible fix as well] Apr 4, 2022 18:52:45 GMT

Quote

Post by DarkTonic Dev on Apr 4, 2022 18:52:45 GMT

I didn't actually test on Mirror, just Photon. A couple users told me it was a painless port so I did it quickly. Now it is being worked on (a fix) by the author of Fish Networking, as well as porting an integration of Mirror to Fish.

If all goes well, that should be in the next update.

Thanks,
-Brian

Master Audio. Mirror. Authority. [possible fix as well]

Post by scornflake on Apr 3, 2022 23:07:36 GMT

Post by scornflake on Apr 4, 2022 11:28:34 GMT

Post by scornflake on Apr 4, 2022 11:39:11 GMT

Post by DarkTonic Dev on Apr 4, 2022 18:20:47 GMT

Post by scornflake on Apr 4, 2022 18:41:49 GMT

Post by DarkTonic Dev on Apr 4, 2022 18:52:45 GMT

Quick Reply