Issues with StopLoopingCurrentSong for breaking out of loop

There's always settings you haven't mentioned that may or may not make this hard to reproduce, so we ask that you always send a small project that reproduces the problem. Please see the official bug reporting rules thread stickied in this forum.

I will watch for your reply!

You have to remove the Master Audio plugin when posting on a PUBLIC page because otherwise it would allow people who didn't even buy it to obtain the source code. I will install the latest version of MA from the Asset Store after downloading your project so it will compile.

I have removed your link.

I will take a look at this soon and report back. Thank you.

EDIT: issue #2 solved when I updated MasterAudio once again.

Thanks! That fix now causes StopLoopingCurrentSong to work with Gapless Music Switching in my project!

The problems discussed here do still remain:

Basically, there are two main issues:
1. A 0.1 second hickup in the framerate when switching from Loop1 to Bridge.  (for reference, the form is Intro, Loop1, Bridge, Loop2)
2. The long gap in audio when switching from Bridge to Loop2.

To address problem 1, I suspected that the hickup is due to loading a long audio (possibly Loop2).  So I added this code that loads all the level's audio at the start of the level:
tracks = plc.CurrentPlaylist.MusicSettings;
foreach (MusicSetting ms in tracks)
clips.Add ((AudioClip)Resources.Load(ms.resourceFileName));

Adding this code seemed to fix the issue.  However, I wonder if I should consider un-loading Intro, Loop1, and Bridge once the song has progressed to Loop2.

As for problem 2, I have discovered why this long gap happens.  During a cutscene while somebody's talking, I will sometimes pause the game (Time.timeScale = 0.0f).  It would seem that the PlaylistController can't switch tracks when the game is paused.  I'll update my test project with a pause feature and send you a link in a bit.

And thanks again for your continued support!

Issue #1 may occasionally be caused by Unity itself, which can hiccup when it finished loading resources that are large sometimes, and thus is not avoidable. You might want to try using the "preload audio data" turned off instead of Resource files and see if that's any better.

Note that the resource loading code and "preload audio data" code that is used for gapless in MA already loads the next clip well in advance so it can schedule the next song. There is substantial code in MA to handle unloading previous songs to minimize on memory usage. If you load all the Resource'd songs at the beginning of the Scene (your code you posted), you lose any memory advantage and you may as well just be using Audio Clips instead of Resource files. Yes that would be better on performance but at the cost of audio memory. All memory from all songs would be initially needed, which is bad.

What I'm saying is that there's no point loading ALL resource clips in a Playlist at the beginning of a Scene (if you have enough memory to do that, why not just use non-Resource files)? The entire point of using Resource files (or Preload Audio Data off) is to minimize the amount of audio memory being consumed at any one time (1 song in memory for non-gapless or 2 songs in memory for gapless). For example if you have 6 songs in a Playlist, and are doing a mobile game, you probably don't have enough memory to load all 6 into memory unless your game doesn't have much in the way of large textures and other assets. So you're forced to use Resource files to avoid crashing the game. Even if you do have the room available, it's a waste of memory really.

So, if you have enough memory to load all the songs at the beginning, then unloading them one by one from memory later doesn't matter much. You have no advantage in doing this, and are wasting time writing that code when you could just use Audio Clips instead of Resource files. AudioResourceOptimizer only loads up a song when it needs to schedule the next song for gapless, or does so much later for non-gapless. In either case, the Resource file is automatically unloaded when the song ends and the audio stops. There is a list of audio files in that class for Playlists as well. You don't need to be concerned with how it works, but it does work.